Fix crash tracking initialization on Windows#10042
Draft
Conversation
amarziali
approved these changes
Nov 27, 2025
Contributor
amarziali
left a comment
amarziali
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix — that recurring log message can definitely be annoying for Windows users. For future improvements, we should handle this scenario more gracefully on Windows, since we may still need to set read permissions for everyone.
Contributor
PerfectSlayer
left a comment
PerfectSlayer
left a comment
There was a problem hiding this comment.
🎯 suggestion: Rather than disabling the RO / RW set, I would implement the Windows related calls:
DosFileAttributeView view = Files.getFileAttributeView(path, DosFileAttributeView.class);
view.setReadOnly(true);I know it's early to give feedback as it's a draft, but I saw it was already approved 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This commit addresses UnsupportedOperationException errors when initializing crash tracking on Windows systems.
Motivation
Instrumenting a java app on Windows currently logs the following warnings:
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]